Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lobby xeno late join queue information #7261

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Oct 2, 2024

About the pull request

This PR adds some xeno queue information when late joining as a xeno from the lobby. It also streamlines the late join xeno from lobby process somewhat (automatically offers observation if there are no afk xenos, and automatically turns on xeno candidacy preference if done so). It also adds the same position estimate to your first cached message if you were to press the join as xeno button when you are presently ineligible.

There is also misc refactoring and additional autodoc comments for related variables.

Explain why it's good for the game

Better new player experience and a bit more information for a player on the lobby to determine whether they want to wait in the xeno queue or late join as a marine.

Testing Photographs and Procedure

Screenshots & Videos

original implementation:
example

Addition to ineligible blub:
image

tgui_alert change:
example2

Changelog

🆑 Drathek
add: Added xeno queue information when attempting a xeno late join while inelgible (from the lobby and first time after death)
qol: Streamlined the xeno late join process from lobby (offers observation and sets xeno preference)
ui: Changed some alerts on main menu to tgui_alert
/:cl:

@cmss13-ci cmss13-ci bot added Feature Feature coder badge Quality of Life Make the game harder to play labels Oct 2, 2024
@ihatethisengine
Copy link
Contributor

now let me see the same number as a xeno who just died

@Drulikar
Copy link
Contributor Author

Drulikar commented Oct 2, 2024

now let me see the same number as a xeno who just died

Ok.
image

@cmss13-ci cmss13-ci bot added the UI deletes nanoui/html label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Quality of Life Make the game harder to play UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants